refactor: Removed not used return values from context. Simplify logic.#515
Open
refactor: Removed not used return values from context. Simplify logic.#515
Conversation
Iogsotot
reviewed
Apr 10, 2023
web/src/connectors/task-annotator-connector/task-annotator-context.tsx
Outdated
Show resolved
Hide resolved
web/src/connectors/task-annotator-connector/task-annotator-context.tsx
Outdated
Show resolved
Hide resolved
web/src/connectors/task-annotator-connector/task-annotator-context.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
The PR is very big and touches on many key points in the application (Context), I think it will be safer to get a second review from Sveta @sbilevich UPD: Are you sure that this PR completely closes the #387? mb it will be better to change the comment from |
nanbratan
force-pushed
the
refactor/task-annotator-context-first-part#387
branch
from
0256a5a to
d306a42
Compare
Iogsotot
approved these changes
Apr 11, 2023
sbilevich
reviewed
Apr 12, 2023
nanbratan
force-pushed
the
refactor/task-annotator-context-first-part#387
branch
from
d306a42 to
d8354ed
Compare
sbilevich
approved these changes
Apr 28, 2023
nanbratan
force-pushed
the
refactor/task-annotator-context-first-part#387
branch
from
d527529 to
fc6faf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387